Aw: Re: code review
[Thread Prev] | [Thread Next]
[Date Prev] | [Date Next]
- Subject: Aw: Re: code review
- From: a.regenfuss@xxxxxx
- Date: Thu, 23 Jun 2016 20:37:38 +0200
- To: myrddin-dev@xxxxxxxxxxxxxx
>- It looks like 'syl' may be used uninitialized if it's not passed as an option [todo on my end: that should fail >to compile]. You are right. Thank you. >- Your man page can also be installed by mbld: >man = syl.1 ;; Aha! I was already wondering how I could do that. >- std.get(tn(line[i]))<<4|std.get(tn(line[i+1]) looks like it could be replaced with >'std.intparsebase(line[i:i+2], 16)'? That is much cleaner. Applied it. >- Congratulations, you found a bug in the compiler: custom 'option-like' types shouldn't work in std.get(), but it >seems like I accidentally ended up duck typing them.. Looks like you need more people testing it.. I am lucky that I can ask the language creator to do a code review. Thank you a lot for your time. Cheers, pranomostro
code review | a.regenfuss@xxxxxx |
Re: code review | Ori Bernstein <ori@xxxxxxxxxxxxxx> |
- Prev by Date: Re: code review
- Previous by thread: Re: code review
- Index(es):