[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: code review
- Subject: Re: code review
- From: Ori Bernstein <ori@xxxxxxxxxxxxxx>
- Date: Tue, 21 Jun 2016 21:33:26 -0700
- To: a.regenfuss@xxxxxx
- Cc: myrddin-dev@xxxxxxxxxxxxxx
More comments:
- It looks like 'syl' may be used uninitialized if it's not passed as an option [todo on my end: that should fail to compile].
- Your man page can also be installed by mbld:
man = syl.1 ;;
- std.get(tn(line[i]))<<4|std.get(tn(line[i+1]) looks like it could be replaced with 'std.intparsebase(line[i:i+2], 16)'?
- Congratulations, you found a bug in the compiler: custom 'option-like' types shouldn't work in std.get(), but it seems like I accidentally ended up duck typing them..
> On Jun 21, 2016, at 11:32 AM, a.regenfuss@xxxxxx wrote:
>
> Dear fellow myrddin programmers,
>
> first things first: I would like to have a little
> bit of myrddin code reviewed. It is for a small
> utility that converts hexadecimal input to urbit
> syllables and the other way around (urbit is a pretty
> good answer to Utah2000).
>
> Here's the code: https://github.com/pranomostro/syl/blob/master/syl.myr
>
> If I'm wrong here, don't hesitate to send me away.
>
> Thanks in advance.
>
> pranomostro
> <syl.myr>