Re: Let pkglocal be the default
[Thread Prev] | [Thread Next]
- Subject: Re: Let pkglocal be the default
- From: "Mura Li" <mail@xxxxxxx>
- Reply-to: myrddin-dev@xxxxxxxxxxxxxx
- Date: Sat, 19 Oct 2019 07:14:38 +0800
- To: "Ori Bernstein" <ori@xxxxxxxxxxxxxx>, myrddin-dev@xxxxxxxxxxxxxx
Okay. I will prepare a patch experimenting with it. Maybe I would find out some unexpected issues along the way. On Sat, Oct 19, 2019, at 12:39 AM, ori@xxxxxxxxxxxxxx wrote: > > I find that the single-file scope is not particularly useful. > > And most of the time the `pkglocal` visibility seems to be the better default. > > Can we make pkglocal the default and get rid of it eventually? > > Any concerns? > > -- > > > > Mura.L > > No particularly strong concerns. I have a mild preference for keeping > it as is, because I like having things as static and local as possible. > I rarely find myself reaching for it in my code, and when I do it seems > to be for an entire package at once where I'm abstracting a set of > platform specific APIs. > > But, again, this isn't a strongly held opinion: making everything pkglocal > by default wouldn't make the code I write any worse, it's just an argument > from purity. If it makes it easier for you to write your code, I'd be ok > with changing it. > > The only technical consideration is usefile bloat -- but that's unlikely > to matter in practice. Especially if generics aren't used too heavily. > >
Re: Let pkglocal be the default | ori@xxxxxxxxxxxxxx |
- Prev by Date: Re: Let pkglocal be the default
- Next by Date: [PATCH] Allow bigdivmod to return remainders between 2^31 and 2^32
- Previous by thread: Re: Let pkglocal be the default
- Next by thread: [PATCH] Allow bigdivmod to return remainders between 2^31 and 2^32
- Index(es):