Eigenstate: myrddin-dev mailing list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix use-after-free in futex-based semaphore implementations.


On Wed, 13 Mar 2019 01:58:49 -0700, iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
  
>  const ulock_wake = {op, uaddr, wakeval
> -	-> (syscall(Sysulock_wake, a(op), uaddr, a(wakeval)) : int)
> +	-> (syscall(Sysulock_wake, a(op), uaddr, wakeval) : int)

the `a(wakeval)` shouldn't have been removed -- it's an ABI thing: Even 32 bit
values go in 64 bit registers on sysv-like platforms. Fixing on my end before
committing.


-- 
    Ori Bernstein

References:
[PATCH] Fix use-after-free in futex-based semaphore implementations.iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>