Eigenstate: myrddin-dev mailing list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix typo in generic sleq implementation


Actually, how about we delete the function and use `std.eq` :)

I think I fixed usages in libstd, but I didn't want to break code
for 0.3.

On Thu, 12 Jul 2018 12:02:57 -0700
iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> ---
>  lib/std/sleq.myr | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/std/sleq.myr b/lib/std/sleq.myr
> index c91f826d..30f49d51 100644
> --- a/lib/std/sleq.myr
> +++ b/lib/std/sleq.myr
> @@ -28,7 +28,7 @@ generic sleq = {a, b
>  
>  impl equatable @a[:] =
>  	eq = {a, b
> -		if a.len == b.len
> +		if a.len != b.len
>  			-> false
>  		;;
>  		/* can't use memeq because of padding */
> -- 
> 2.18.0
> 
> 


-- 
Ori Bernstein <ori@xxxxxxxxxxxxxx>

Follow-Ups:
Re: [PATCH] Fix typo in generic sleq implementationOri Bernstein <ori@xxxxxxxxxxxxxx>
References:
[PATCH] Fix typo in generic sleq implementationiriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>