Re: [PATCH] Fix auto expressions for complex values.

[Ori Bernstein <ori@xxxxxxxxxxxxxx>]

I had actually run into this the other day, too. Applied.

I'd like to start using this a lot more pervasively throughout libstd and friends :)

On Fri, 6 Jul 2018 16:37:42 +0000, Quentin Carbonneaux <quentin@xxxxxx> wrote:

> Hello Myrddin folks,
> 
> The current code to handle auto expressions does not correctly
> deal with complex values (i.e., values that do not fit in a
> register).  This patch attempts to fix the issue.
> 
> -- Quentin
> 
> ---
>  mi/flatten.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mi/flatten.c b/mi/flatten.c
> index 022ffe4f..5a749962 100644
> --- a/mi/flatten.c
> +++ b/mi/flatten.c
> @@ -537,9 +537,8 @@ rval(Flattenctx *s, Node *n)
>  	args = n->expr.args;
>  	switch (exprop(n)) {
>  	case Oauto:
> -		r = rval(s, n->expr.args[0]);
> -		t = temp(s, r);
> -		r = asn(t, r);
> +		t = temp(s, n);
> +		r = assign(s, t, n->expr.args[0]);
>  		lappend(&s->curst->autotmp, &s->curst->nautotmp, t);
>  		break;
>  	case Osize:
> -- 
> 2.16.2
> 


-- 
    Ori Bernstein