Re: [PATCH 0/2] Signedness of bits from floats

[Ori Bernstein <ori@xxxxxxxxxxxxxx>]

On Tue, 27 Feb 2018 22:54:17 -0500, "S. Gilles" <sgilles@xxxxxxxxxxxx> wrote:

> After some thought, I believe it's useful to have the same signedness
> when converting between flts and bits (patch 1). In the process, I
> found a small bug in isnan() (patch 2). Tests are added to hopefully
> prevent me from breaking everything.
> 
> There was also a "22" in flt32assem that I'm pretty sure should
> be a "23" (also in patch 2), but that function doesn't appear used,
> so that's not a big deal.
> 
> S. Gilles (2):
>   Adjust signs of fltbits functions
>   Test some fltbits functions
> 
>  lib/std/fltbits.myr      | 44 +++++++++++-----------
>  lib/std/fltfmt.myr       |  2 +-
>  lib/std/fltparse.myr     |  4 +-
>  lib/std/test/fltbits.myr | 95 +++++++++++++++++++++++++++++++++++++++++++++++-
>  4 files changed, 120 insertions(+), 25 deletions(-)
> 

LGTM.

Quick note, I recently added testr.eq, testr.neq, which gives a convenient
way of checking if two values are the same. (I should document them.)

-- 
    Ori Bernstein