Eigenstate: myrddin-dev mailing list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] Make timespec/timeval struct members signed to simplify arithmetic.


On Sat, 11 Aug 2018 19:11:19 -0700, iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> Every single conversion except for one for OS X is uint64 to int64.
> 
> ---
>  lib/std/syswrap+posixy.myr                    |  2 +-
>  lib/std/syswrap-ss+freebsd.myr                |  4 ++--
>  lib/std/syswrap-ss+linux.myr                  |  4 ++--
>  lib/std/syswrap-ss+netbsd.myr                 |  4 ++--
>  lib/std/syswrap-ss+openbsd.myr                |  4 ++--
>  lib/std/syswrap-ss+osx.myr                    |  4 ++--

>  lib/sys/sys+freebsd-x64.myr                   |  8 +++----
>  lib/sys/sys+linux-x64.myr                     |  8 +++----
>  lib/sys/sys+netbsd-x64.myr                    |  8 +++----
>  lib/sys/sys+openbsd-x64.myr                   | 10 ++++----

Quick note, we may want to these changes into our
syscall generation code. Right now, that bit is
crappy (we don't automatically regenerate system
call files), but we should at least be keeping
things in sync so that when we add new, say,
OpenBSD releases, things don't mysteriously
go out of sync.

Take a look at mc/support/syscall-gen


-- 
    Ori Bernstein

Follow-Ups:
[PATCH 1/4] Make timespec/timeval struct members signed to simplify arithmetic.iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References:
[PATCH 1/4] Make timespec/timeval struct members signed to simplify arithmetic.iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>