Eigenstate: myrddin-dev mailing list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Fix futex timeouts, handle futex error codes, and add mtxtimedlock, semtimedwait, and condtimedwait.


On Sat, 28 Jul 2018 17:57:43 -0700, iriri <iri@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> Having `ftxwait` return `sys.errno` rather than a union type feels somewhat questionable. The fallbacks, as always, are also somewhat questionable.
> 
> Handling `sys.Eintr` within `ftxwait` seems better than having to handle it everywhere `ftxwait` gets used.

Also, while the patch applies (after some tweaks -- I landed a few
fixes recently), it doesn't actually compile, everywhere. There's a
stray comma in futex+freebsd.myr:29

Fixing that, there are a few more type errors. Similarly, OpenBSD has
a few issues:

	lib/sys/sys+openbsd:6.3-x64.myr:1176: type "int64" incompatible with "uint64" near time:uint64

If you need access to infrastructure where you can build these, I can take a look at
setting up a few test systems over the weekend, and give you access.

-- 
    Ori Bernstein