Eigenstate: myrddin-dev mailing list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 1/2] Add impl(type, name) to retrieve a particular implementation of a trait decl


Sorry, I was a bit slow patching it in and trying it out. There are a few
minor nits, but I think it's pretty much good enough.

On Sat,  1 Jul 2017 14:43:21 -0700, Michael Forney <mforney@xxxxxxxxxxx> wrote:

> @@ -1265,6 +1266,10 @@ TABLE OF CONTENTS:
>              match, again, given that it is never read from in the body of the
>              match.
>  
> +            An impl expression chooses the implementation of the given trait
> +            declaration for the given type. It is useful for refering to trait
> +            declarations in a generic context.
> +

It's probably worth specifying here the restrictions on what this does --
specifically, the requirement that the name must be a declaration from within
a trait. Otherwise, looks good.

-- 
    Ori Bernstein

References:
[RFC PATCH 0/2] impl specialization and lookup changesMichael Forney <mforney@xxxxxxxxxxx>
[RFC PATCH 1/2] Add impl(type, name) to retrieve a particular implementation of a trait declMichael Forney <mforney@xxxxxxxxxxx>