Re: [mcbind] [PATCH 2/4] Add `Einit where necessary to complete matchings
[Thread Prev] | [Thread Next]
[Date Prev] | [Date Next]
- Subject: Re: [mcbind] [PATCH 2/4] Add `Einit where necessary to complete matchings
- From: Ori Bernstein <ori@xxxxxxxxxxxxxx>
- Reply-to: myrddin-dev@xxxxxxxxxxxxxx
- Date: Sat, 11 Apr 2020 11:01:04 -0700
- To: myrddin-dev@xxxxxxxxxxxxxx
- Cc: "S. Gilles" <sgilles@xxxxxxx>
I think it's fine -- init is really a pseudoexpression as far as I can tell. (Also, side note -- I got distracted, and kept forgetting to come back to this -- if I don't respond after a week or so, please ping.) On Tue, 10 Mar 2020 11:47:49 -0400, "S. Gilles" <sgilles@xxxxxxx> wrote: > --- > I'm not actually sure that returning Tyvoid is correct here. I think > it's been a while since I intentionally invoked "force a correct patch > by submitting a broken one", so perhaps I may be forgiven. > > ast.myr | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ast.myr b/ast.myr > index 0b9c3cc..245f84d 100644 > --- a/ast.myr > +++ b/ast.myr > @@ -301,6 +301,7 @@ const exprtype = {e > | &(`Ecall call): -> call.functy.rty > | &(`Eincdec incdec): -> exprtype(incdec.expr) > | &(`Esizeof _): -> `Tyint > + | &(`Einit _): -> `Tyvoid > ;; > } > > @@ -326,6 +327,7 @@ const exprloc = {e > | &(`Ecall _): > | &(`Eincdec _): > | &(`Esizeof _): > + | &(`Einit _): > ;; > -> [.file=[][:], .line=0, .col=0 ] > } > -- > 2.25.1 > > -- Ori Bernstein