[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Respect outfile
- Subject: Re: [PATCH] Respect outfile
- From: Ryan Gonzalez <rymg19@xxxxxxxxx>
- Date: Thu, 15 Jan 2015 20:45:49 -0600
- To: Ori Bernstein <ori@xxxxxxxxxxxxxx>
- Cc: myrddin-dev@xxxxxxxxxxxxxx
I usually just download the patch myself and use git apply:
$ git apply patchfile.diff
$ git commit -m "..."
On another note, does the -I argument to 6m work? I've been experiment, but
it doesn't seem to be picking up my use file.
On Thu, Jan 15, 2015 at 6:37 PM, Ori Bernstein <ori@xxxxxxxxxxxxxx> wrote:
> No worries -- first time I've used git am, so I'm just figuring out how to
> use it.
>
> It seems to take the body of the email and applies all the patches in it
> as one
> commit, so if you have HTML, it looks like I have to amend the commit to
> get
> a nice message.
>
> On Jan 15, 2015, at 4:27 PM, Ryan <rymg19@xxxxxxxxx> wrote:
>
>
>
> Ori Bernstein <ori@xxxxxxxxxxxxxx> wrote:
>
> Figured out git-am and applied it; next time, one plain text email per
> patch should work best .
>
>
> Sorry.
>
>
> Also, fixed one small bug: strncpy() doesn't null terminate. snprintf()
> is preferred. And yes, C string handling functions suck.
>
>
>
> On Jan 15, 2015, at 12:22 PM, Ryan Gonzalez <rymg19@xxxxxxxxx> wrote:
>
> I'm not sure what Myrddin's contributing guidelines are, so I'm doing
>
> things the hg-git way of sending the patch to the mailing list.
>
>
> This is really simple: it just actually uses outfile. If someone
>
> specifies an output file, then it will be used as the output for the
> object file; the output's basename will also be used for the use file
> and the assembler file (if -S was passed).
>
>
> Another patch is attached that fixes a slight logic error in the man
>
> page that confused me very much. :)
>
>
> --
> Ryan
> If anybody ever asks me why I prefer C++ to C, my answer will be
>
> simple: "It's becauseslejfp23(@#Q*(E*EIdc-SEGFAULT. Wait, I don't think
> that was nul-terminated."
>
> Personal reality distortion fields are immune to contradictory
>
> evidence. - srean
>
> Check out my website: http://kirbyfan64.github.io/
> <patch.diff><man.diff>
>
>
> --
> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
> Check out my website: http://kirbyfan64.github.io/
>
>
>
--
Ryan
If anybody ever asks me why I prefer C++ to C, my answer will be simple:
"It's becauseslejfp23(@#Q*(E*EIdc-SEGFAULT. Wait, I don't think that was
nul-terminated."
Personal reality distortion fields are immune to contradictory evidence. -
srean
Check out my website: http://kirbyfan64.github.io/